Skip to content

Detect and avoid 404 and 500 error pages#893

Merged
fregante merged 1 commit into
masterfrom
handle-error-pages
Dec 20, 2017
Merged

Detect and avoid 404 and 500 error pages#893
fregante merged 1 commit into
masterfrom
handle-error-pages

Conversation

@fregante
Copy link
Copy Markdown
Member

@fregante fregante commented Dec 20, 2017

Without this there would be errors in the console. Not a big deal but it's 3 lines of code that might be useful for #485

@fregante fregante added the bug label Dec 20, 2017
@fregante fregante merged commit fb590a1 into master Dec 20, 2017
@fregante fregante deleted the handle-error-pages branch December 20, 2017 09:01
@busches
Copy link
Copy Markdown
Member

busches commented Dec 20, 2017

GHE still has the bullet instead of the dash, using startsWith would work still, any reason you made it so specific?

@fregante
Copy link
Copy Markdown
Member Author

fregante commented Dec 20, 2017

Because an issue can start with that title, check out the new tests in this PR. You can submit a PR to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants