Repository navigation
Restore bugs-tab and releases-tab title - #4134
Merged
Merged
Conversation
bug-tab and release-tab titlebugs-tab and release-tab title
bugs-tab and release-tab titlebugs-tab and releases-tab title
Member
|
That's a useless tooltip. It only makes sense if the number has been shortened, not always. |
Member
Author
|
Worth the if statement? |
fregante
approved these changes
Mar 19, 2021
Member
There was a problem hiding this comment.
Related #3633 (comment)
😃
Worth the if statement?
Good point, but thankfully we can use ternary operators.
Merge after these changes:
| // Set temporary counter | ||
| const bugsCounter = select('.Counter', bugsTab)!; | ||
| bugsCounter.textContent = '0'; | ||
| bugsCounter.title = ''; |
Member
There was a problem hiding this comment.
We still need to reset this as soon as possible because the count is loaded later
yakov116
commented
Mar 21, 2021
Co-authored-by: Federico <me@fregante.com>
Member
Author
But typescript does not like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4133