table-input - Restore feature in PR page - #10002
Open
kovsu wants to merge 4 commits into
Open
Conversation
The new PR "Files changed" view wraps inline comment editors in `div[data-inline-markers]`, whose React handler stops click propagation, so the document-level `delegate` never received the squares' clicks: the menu opened and closed but nothing was inserted. Listen on the injected `<details>` instead, below the interception point. Also remove a stray "," text node inside the `<details>`, left over from the JSX conversion in refined-github#9845.
table-input - Fix table insertion on the new "Files changed" viewtable-input - Restore feature in PR page
fregante
requested changes
Aug 25, 2026
fregante
reviewed
Aug 25, 2026
fregante
reviewed
Aug 27, 2026
| import {withTooltipRef} from '../components/tooltip.js'; | ||
|
|
||
| function addTable({delegateTarget: square}: DelegateEvent<MouseEvent, HTMLButtonElement>): void { | ||
| closestElement('details', square).open = false; |
Member
There was a problem hiding this comment.
I saw your commit title, but I don't see the bug that this and capture are fixing. What's your browser? The table is inserted and the field is focused in Safari:
Member
Author
There was a problem hiding this comment.
In the PR review page, like https://github.com/refined-github/refined-github/pull/10002/changes
Member
There was a problem hiding this comment.
We need inline comments explaining what code does, why, and where
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test URLs
Any PR page
Screenshot
CleanShot.2026-08-25.at.15.45.27.mp4
CleanShot.2026-08-25.at.16.04.43.mp4