Skip to content

Permit the ServiceBrowser to browse overlong types#666

Merged
bdraco merged 4 commits into
python-zeroconf:masterfrom
bdraco:allow_browsing_overlength_types
Jun 16, 2021
Merged

Permit the ServiceBrowser to browse overlong types#666
bdraco merged 4 commits into
python-zeroconf:masterfrom
bdraco:allow_browsing_overlength_types

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 15, 2021

  • At least one type "tivo-videostream" exists in the wild
    so we are permissive about what we will look for, and
    strict about what we will announce.

Fixes #661 Fixes #311

bdraco added 3 commits June 15, 2021 13:42
- At least one type "tivo-videostream" exists in the wild
  so we are permissive about what we will look for, and
  strict about what we will announce.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #666 (f6491b4) into master (5752ace) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   97.25%   97.35%   +0.09%     
==========================================
  Files          17       17              
  Lines        2074     2076       +2     
  Branches      359      360       +1     
==========================================
+ Hits         2017     2021       +4     
+ Misses         34       33       -1     
+ Partials       23       22       -1     
Impacted Files Coverage Δ
zeroconf/_utils/name.py 100.00% <100.00%> (ø)
zeroconf/_core.py 96.28% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5752ace...f6491b4. Read the comment docs.

@bdraco bdraco merged commit e76c7a5 into python-zeroconf:master Jun 16, 2021
@bdraco bdraco deleted the allow_browsing_overlength_types branch June 16, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async and sync browser examples fail when there are services with > 15 chars Allow >15 character service_type_name when strict is False

2 participants