Skip to content

Allow >15 character service_type_name when strict is False #311

@garethsb

Description

@garethsb

I saw that 0.28.6 has added a more relaxed service type name checking mode, not just allowing underscores.

Bonjour also allows mDNS service type names longer than 15 characters in fact, despite the clear requirement in RFC6335.
We have dealt with deployments using overlong names by monkey patching python-zeroconf to skip the len(test_service_name) > 15 check.

So I hoped strict=False would work for me.

However, I see that the condition for doing most of the checks is now strict or has_protocol... why not just strict?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions