Skip to content

Fix ServiceBrowser infinite looping when zeroconf is closed before its canceled #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Oct 10, 2021
Merged

Fix ServiceBrowser infinite looping when zeroconf is closed before its canceled #1008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions zeroconf/_services/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,6 @@ def reschedule_type(self, type_: str, next_time: float) -> None:

def _async_send_ready_queries(self) -> None:
"""Send any ready queries."""
if self.done or self.zc.done:
return

outs = self._generate_ready_queries(self._first_request)
if outs:
self._first_request = False
Expand All @@ -476,6 +473,8 @@ def _async_send_ready_queries(self) -> None:

def _async_send_ready_queries_schedule_next(self) -> None:
"""Send ready queries and schedule next one."""
if self.done or self.zc.done:
return
self._async_send_ready_queries()
self._async_schedule_next()

Expand Down