Skip to content

Fix ServiceBrowser infinite looping when zeroconf is closed before its canceled#1008

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:guard_type_refresh_shutdown_race
Oct 10, 2021
Merged

Fix ServiceBrowser infinite looping when zeroconf is closed before its canceled#1008
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:guard_type_refresh_shutdown_race

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Oct 10, 2021

  • If the ServiceBrowser was not canceled before Zeroconf was closed
    out, and it was not started by Zeroconf itself, it could lead
    to an infinite scheduling loop

Fixes #1005

…s canceled

- If the ServiceBrowser was not canceled before Zeroconf was closed
  out, and it was not started by Zeroconf itself, it could lead
  to an infinite scheduling loop
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #1008 (ad4a872) into master (fec9f3d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          23       23           
  Lines        2504     2504           
  Branches      409      409           
=======================================
  Hits         2498     2498           
  Misses          3        3           
  Partials        3        3           
Impacted Files Coverage Δ
zeroconf/_services/browser.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec9f3d...ad4a872. Read the comment docs.

@bdraco bdraco merged commit b0e8c8a into python-zeroconf:master Oct 10, 2021
@bdraco bdraco deleted the guard_type_refresh_shutdown_race branch October 10, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_ServiceBrowserBase._async_send_ready_queries_schedule_next() blocking?

2 participants