Skip to content

Remove duplicate blockMode assignment in compress_begin #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devdanzin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove duplicate blockMode assignment in compress_begin #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: remove duplicate blockMode assignment in compress_begin 
The blockMode preference is set at lines 321-328 and then identically
again at lines 348-355 in compress_begin. Remove the second redundant
assignment.

Found using cext-review-toolkit (https://github.com/devdanzin/cext-review-toolkit).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
  • Loading branch information
@devdanzin @claude
devdanzin and claude committed Apr 1, 2026
commit 3d4f41b826b79ebfdc29992628cdcf13ab199a44
10 changes: 0 additions & 10 deletions lz4/frame/_frame.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,16 +345,6 @@ compress_begin (PyObject * Py_UNUSED (self), PyObject * args,
return NULL;
}

if (block_linked)
{
preferences.frameInfo.blockMode = LZ4F_blockLinked;
}
else
{
preferences.frameInfo.blockMode = LZ4F_blockIndependent;
}


preferences.frameInfo.contentSize = source_size;

context =
Expand Down
Loading