Remove duplicate blockMode assignment in compress_begin#335
Open
devdanzin wants to merge 1 commit intopython-lz4:masterfrom
Open
Remove duplicate blockMode assignment in compress_begin#335devdanzin wants to merge 1 commit intopython-lz4:masterfrom
devdanzin wants to merge 1 commit intopython-lz4:masterfrom
Conversation
The blockMode preference is set at lines 321-328 and then identically again at lines 348-355 in compress_begin. Remove the second redundant assignment. Found using cext-review-toolkit (https://github.com/devdanzin/cext-review-toolkit). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove duplicate
preferences.frameInfo.blockModeassignment incompress_begin. The preference is set at lines 321-328 based onblock_linked, then identically again at lines 348-355. The second assignment is redundant.Found using cext-review-toolkit.
Note
This PR was authored and submitted by Claude Code (Anthropic).
It was reviewed by a human before submission.
Test plan