Test the from_networkx int32 widening and correct its coverage claim - #618
Open
eriknw wants to merge 1 commit into
Open
Test the from_networkx int32 widening and correct its coverage claim#618eriknw wants to merge 1 commit into
eriknw wants to merge 1 commit into
Conversation
eriknw
force-pushed
the
37-networkx-int32-widen-pin
branch
from
August 5, 2026 17:44
ea9890e to
e21ed55
Compare
eriknw
force-pushed
the
37-networkx-int32-widen-pin
branch
from
August 5, 2026 18:03
e21ed55 to
b320caa
Compare
eriknw
force-pushed
the
37-networkx-int32-widen-pin
branch
2 times, most recently
from
August 6, 2026 07:59
62b13c7 to
9efbea8
Compare
eriknw
force-pushed
the
37-networkx-int32-widen-pin
branch
from
August 6, 2026 15:39
9efbea8 to
b747942
Compare
eriknw
force-pushed
the
37-networkx-int32-widen-pin
branch
2 times, most recently
from
August 6, 2026 20:36
402b89a to
ba98df4
Compare
eriknw
force-pushed
the
37-networkx-int32-widen-pin
branch
from
August 6, 2026 20:41
ba98df4 to
a557f7e
Compare
eriknw
force-pushed
the
37-networkx-int32-widen-pin
branch
from
August 7, 2026 02:49
a557f7e to
50ef9e9
Compare
The widening added while stabilizing CI was marked "pragma: no cover (win64 numpy < 2)", but the branch is reachable on every platform: np.int32 scalar edge weights infer an int32 array from the edge sequence anywhere, not only where python ints do. The pragma therefore hid live code from coverage, and the comment implied the change was platform-local when it is user-visible everywhere: int32-weighted graphs that previously round-tripped through scipy as INT32 now come back INT64. The widening itself is kept, deliberately. from_coo widens an int32 dtype inferred from sequence input to int64 on every platform (values_to_numpy_buffer), and from_networkx builds its values from a Python sequence, so identical weights now produce the same dtype through either constructor. Gating the widening to win64 instead would have re-introduced a from_coo/from_networkx disagreement everywhere else. Drop the pragma, restate the comment in terms of the real contract, and pin the behavior: np.int32 weights widen to INT64 and agree with from_coo, an explicit dtype= is preserved exactly, and np.int16 stays INT16 through both constructors. Release-note item: the from_networkx result dtype for int32-weighted graphs changes from INT32 to INT64.
eriknw
force-pushed
the
37-networkx-int32-widen-pin
branch
from
August 7, 2026 05:09
50ef9e9 to
f5f70f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #617. Overnight review of the late CI-stabilization commits found that the int32-to-int64 widening in
from_networkx(added in #600's18a5ad22) is reachable on every platform, not only win64 with numpy < 2 as itspragma: no coverclaimed:np.int32scalar edge weights infer an int32 array from the edge sequence anywhere.The widening is deliberate and kept:
from_coowidens int32 inferred from sequence input to int64 on every platform (values_to_numpy_buffer), andfrom_networkxbuilds its values from a Python sequence, so identical weights now produce the same dtype through either constructor:This PR drops the false pragma, restates the comment in terms of the real contract, and pins the behavior with tests: int32 weights widen and agree with
from_coo, explicitdtype=is preserved exactly, and int16 stays INT16 through both constructors.Release-note item: the
from_networkxresult dtype for int32-weighted graphs changes from INT32 to INT64 (2x value storage). If instead the old INT32 result is wanted, the widening condition is one line, but thenfrom_networkxandfrom_coodisagree for identical weights.