Reject building a user monoid from a built-in BinaryOp - #617
Open
eriknw wants to merge 1 commit into
Open
Conversation
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
August 5, 2026 03:18
dbce7b2 to
488622d
Compare
This was referenced Aug 5, 2026
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
August 5, 2026 17:44
488622d to
8f138a4
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
August 5, 2026 18:03
8f138a4 to
2c9fdaa
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
August 5, 2026 18:05
2c9fdaa to
88922bd
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
August 6, 2026 07:59
88922bd to
99668c2
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
August 6, 2026 15:39
99668c2 to
1b70585
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
August 6, 2026 15:41
1b70585 to
076218f
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
2 times, most recently
from
August 6, 2026 20:41
1ddb541 to
dd0e7ef
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
August 7, 2026 02:49
dd0e7ef to
35065c5
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
August 7, 2026 05:09
35065c5 to
727fe12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering a monoid from a built-in binaryop used to crash partway
through construction:
and by the time it raised, it had already repointed binary.max's monoid
association at the half-built monoid, so binary.max.monoid stayed
corrupted for the rest of the session. (This is the latent bug that the
fmax/fmin identity test surfaced on mapnumpy=True CI runs.)
Even patched over, the result would lie. SuiteSparse ignores the
identity passed to GrB_Monoid_new whenever the built-in op already has a
built-in monoid, measured with GxB_Monoid_identity:
The override applies to exactly the ops that have built-in monoids (max,
min, plus, times, any) and not the rest (minus, first, second, pow,
bor, lxor), so a permissive fix would produce a monoid whose Python-side
identity silently disagrees with what GraphBLAS computes with. If a
monoid over a built-in op's function made sense, the built-in monoid
would already exist.
Monoid._build now rejects built-in binaryops up front with a TypeError
that points at BinaryOp.register_new / register_anonymous as the way to
build a monoid over the same function with a chosen identity. Built-ins
are detected as ops with neither a Python function nor a numba function,
which also covers assembled ops like binary.numpy.float_power. The
rejection happens before any object is created, so nothing is mutated on
the failing path.