Repository navigation
feat(api): add ListMixin to remaining *DiscussionNoteManagers - #3423
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3423 +/- ##
==========================================
+ Coverage 92.23% 95.78% +3.54%
==========================================
Files 100 100
Lines 6172 6172
==========================================
+ Hits 5693 5912 +219
+ Misses 479 260 -219
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Ping @JohnVillalovos for visibility, since you were involved in the referenced issue/MR. |
There was a problem hiding this comment.
Pull request overview
This PR completes the notes API parity work by ensuring the remaining *DiscussionNoteManager implementations support listing discussion notes (via CRUDMixin, which includes ListMixin), and cleans up unused mixin imports in the notes objects module.
Changes:
- Switch
{GroupEpic,ProjectCommit,ProjectSnippet}DiscussionNoteManagerfrom explicit{Get,Create,Update,Delete}Mixinbases toCRUDMixin(thereby adding list support). - Remove now-unused
{Create,Delete,Get,Update}Mixinimports fromgitlab/v4/objects/notes.py.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnVillalovos
force-pushed
the
pcdnm-list
branch
from
July 27, 2026 05:31
484bf40 to
4e53865
Compare
JohnVillalovos
enabled auto-merge (rebase)
July 27, 2026 05:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #3422
{GroupEpic,ProjectCommit,ProjectSnippet}DiscussionNoteManager{Create,Delete,Get,Update}Mixinimports fromgitlab/v4/objects/notes.pyDocumentation and testing
This PR is a simple remix of #3233. Since it didn't contain tests, I have not added them here either.