Repository navigation
Update notes api for ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager - #3233
Merged
JohnVillalovos merged 2 commits intoJul 18, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API for discussion note managers by replacing explicit mixin inheritance with a more concise CRUDMixin approach for both issue and merge request discussion notes.
- Consolidates multiple explicit mixins (GetMixin, CreateMixin, UpdateMixin, DeleteMixin) into a single CRUDMixin for cleaner inheritance
- Updates both ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager classes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3233 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 98 98
Lines 6058 6058
=======================================
Hits 5896 5896
Misses 162 162
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
@massimiliano96 This looks good to me. Only suggestion is that in one of the commit messages add a So that when it gets merged the issue will get closed. |
massimiliano96
force-pushed
the
update-notes-api
branch
from
July 18, 2025 16:08
15ff9d5 to
91dc47a
Compare
JohnVillalovos
approved these changes
Jul 18, 2025
JohnVillalovos
left a comment
Member
There was a problem hiding this comment.
LGTM
Thanks @massimiliano96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add ListMixin to ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager