Repository navigation
ProjectMergeRequestDiscussionNoteManager is missing ListMixin #3180
Description
Description of the problem, including code/CLI snippet
from gitlab import Gitlab
project = Gitlab("https://gitlab.gnome.org").projects.get(456)
mr = project.mergerequests.get(3680)
discussion = mr.discussions.list()[0]
notes = discussion.notes.list()Expected Behavior
This returns a list of notes on the discussion
Actual Behavior
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'ProjectMergeRequestDiscussionNoteManager' object has no attribute 'list'
Workaround:
from gitlab.mixins import ListMixin
notes = ListMixin.list(discussion.notes)Specifications
- python-gitlab version: 5.3.1 (but looks like the mixin is missing on main branch too)
- Gitlab server version (or gitlab.com): N/A
Activity
github-actions commentedon Jun 25, 2025
This issue was marked stale because it has been open 60 days with no activity. Please remove the stale label or comment on this issue. Otherwise, it will be closed in 15 days.
As an open-source project, we rely on community contributions to address many of the reported issues. Without a proposed fix or active work towards a solution it is our policy to close inactive issues. This is documented in CONTRIBUTING.rst
How to keep this issue open: * If you are still experiencing this issue and are willing to investigate a fix, please comment and let us know. * If you (or someone else) can propose a pull request with a solution, that would be fantastic. * Any significant update or active discussion indicating progress will also prevent closure.
We value your input. If you can help provide a fix, we'd be happy to keep this issue open and support your efforts.
massimiliano96 commentedon Jul 17, 2025
Any updates on this? If not, I can take care of it.
It should be enough to add ListMixin to
ProjectMergeRequestDiscussionNoteManager.Though for clarity, it might be even better to directly use
CRUDMixin, like so:class ProjectMergeRequestDiscussionNoteManager(CRUDMixin[ProjectMergeRequestDiscussionNote])JohnVillalovos commentedon Jul 17, 2025
@massimiliano96 PRs welcome. Thanks.
massimiliano96 commentedon Jul 18, 2025
@JohnVillalovos this is the PR: #3233
Let me know if anything should be added or adjusted.
feat(api): add ListMixin to ProjectMergeRequestDiscussionNoteManager
feat(api): add ListMixin to ProjectMergeRequestDiscussionNoteManager
feat(api): add ListMixin to ProjectMergeRequestDiscussionNoteManager