-
-
Notifications
You must be signed in to change notification settings - Fork 14
Split linting from main workflow #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.15
Are you sure you want to change the base?
Changes from all commits
9a6855e
c54b55a
d0ab3ba
08b7f0b
de91514
9a081e8
24516e4
2c4d6f4
2ac3748
9577fed
79d6f8b
977eacf
cf76331
db9f6e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: lint | ||
|
|
||
| on: # zizmor: ignore[dangerous-triggers] | ||
| workflow_run: | ||
| workflows: [update and build] | ||
| types: [completed] | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| version: [3.15, 3.14, 3.13, 3.12, 3.11] | ||
| continue-on-error: true | ||
| steps: | ||
| - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 | ||
| with: | ||
| python-version: 3 | ||
| - run: pip install sphinx-lint | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| ref: ${{ matrix.version }} | ||
| persist-credentials: false | ||
| - uses: rffontenelle/sphinx-lint-problem-matcher@4270bf50b2c93640a7cbb231c09f8e694699af9f # v1.0.0 | ||
| - run: sphinx-lint | ||
|
|
||
| lint-epub: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| version: [3.15, 3.14] | ||
| continue-on-error: true | ||
| steps: | ||
| - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 | ||
| with: | ||
| python-version: 3.x | ||
| - uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0 | ||
| - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| with: | ||
| name: build-${{ matrix.version }}-epub | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will need read permissions (which we don't give above with |
||
| - run: uvx epubcheck | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| name: Translation and Linting Workflow | ||||||
| name: update and build | ||||||
|
|
||||||
| on: | ||||||
| schedule: | ||||||
|
|
@@ -71,26 +71,6 @@ jobs: | |||||
| branch: ${{ matrix.version }} | ||||||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||||||
|
|
||||||
| lint: | ||||||
| runs-on: ubuntu-latest | ||||||
| strategy: | ||||||
| fail-fast: false | ||||||
| matrix: | ||||||
| version: [3.15, 3.14, 3.13, 3.12, 3.11] | ||||||
| needs: [update] | ||||||
| continue-on-error: true | ||||||
| steps: | ||||||
| - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 | ||||||
| with: | ||||||
| python-version: 3 | ||||||
| - run: pip install sphinx-lint | ||||||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||||||
| with: | ||||||
| ref: ${{ matrix.version }} | ||||||
| persist-credentials: false | ||||||
| - uses: rffontenelle/sphinx-lint-problem-matcher@4270bf50b2c93640a7cbb231c09f8e694699af9f # v1.0.0 | ||||||
| - run: sphinx-lint | ||||||
|
|
||||||
| build: | ||||||
| runs-on: ubuntu-latest | ||||||
| strategy: | ||||||
|
|
@@ -120,8 +100,10 @@ jobs: | |||||
| - run: sudo apt-get update && sudo apt-get install -y librsvg2-bin | ||||||
| if: ${{ matrix.format == 'latex' && fromJSON(matrix.version) >= 3.14 }} | ||||||
| - uses: sphinx-doc/github-problem-matcher@1f74d6599f4a5e89a20d3c99aab4e6a70f7bda0f # v1.1 | ||||||
| - run: make -e SPHINXOPTS="--color -D language='pl' -W --keep-going" ${{ matrix.format }} | ||||||
| - run: make -e SPHINXOPTS="--color -D language='pl' --keep-going" ${{ matrix.format }} | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Without |
||||||
| working-directory: ./Doc | ||||||
| env: | ||||||
| SPHINXERRORHANDLING: '' | ||||||
| - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||||||
| if: success() || failure() | ||||||
| with: | ||||||
|
|
@@ -131,6 +113,7 @@ jobs: | |||||
| output-pdf: | ||||||
| runs-on: ubuntu-latest | ||||||
| strategy: | ||||||
| fail-fast: false | ||||||
| matrix: | ||||||
| version: [3.15, 3.14, 3.13, 3.12, 3.11, '3.10'] | ||||||
| needs: [build] | ||||||
|
|
@@ -145,20 +128,3 @@ jobs: | |||||
| with: | ||||||
| name: build-${{ matrix.version }}-pdf | ||||||
| path: . | ||||||
|
|
||||||
| lint-epub: | ||||||
| runs-on: ubuntu-latest | ||||||
| strategy: | ||||||
| matrix: | ||||||
| version: [3.15, 3.14] | ||||||
| needs: [build] | ||||||
| continue-on-error: true | ||||||
| steps: | ||||||
| - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 | ||||||
| with: | ||||||
| python-version: 3.x | ||||||
| - uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0 | ||||||
| - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||||||
| with: | ||||||
| name: build-${{ matrix.version }}-epub | ||||||
| - run: uvx epubcheck | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this include failures,
lint-epubwill need gating for that as otherwise it'll scream when it tries to download the artefact.