Split linting from main workflow#144
Conversation
|
Posted a PR fixing the failure cause: python/cpython#151343 |
Thanks, merged! |
|
|
||
| on: # zizmor: ignore[dangerous-triggers] | ||
| workflow_run: | ||
| workflows: [update-and-build] |
There was a problem hiding this comment.
I think you'll need to match the name here, it's not running currently.
There was a problem hiding this comment.
Thanks, fixed. Though it looks we need to merge as the listening workflow needs to be on main.
| - run: git add . | ||
| - run: git commit -m "$(python manage_translation.py generate_commit_msg)" | ||
| if: env.SIGNIFICANT_CHANGES | ||
| - name: Push commit |
There was a problem hiding this comment.
This shouldn't run on PRs IMO. This causes issues like https://github.com/python/python-docs-pl/actions/runs/27407678283/job/81000784306?pr=144.
| - uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0 | ||
| - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| with: | ||
| name: build-${{ matrix.version }}-epub |
There was a problem hiding this comment.
This will need read permissions (which we don't give above with permissions: {}), and passed a run-id, see https://github.com/actions/download-artifact#download-artifacts-from-other-workflow-runs-or-repositories.
| if: ${{ matrix.format == 'latex' && fromJSON(matrix.version) >= 3.14 }} | ||
| - uses: sphinx-doc/github-problem-matcher@1f74d6599f4a5e89a20d3c99aab4e6a70f7bda0f # v1.1 | ||
| - run: make -e SPHINXOPTS="--color -D language='pl' -W --keep-going" ${{ matrix.format }} | ||
| - run: make -e SPHINXOPTS="--color -D language='pl' --keep-going" ${{ matrix.format }} |
There was a problem hiding this comment.
| - run: make -e SPHINXOPTS="--color -D language='pl' --keep-going" ${{ matrix.format }} | |
| - run: make -e SPHINXOPTS="--color -D language='pl'" ${{ matrix.format }} |
Without -W I don't think we need it any more?
| on: # zizmor: ignore[dangerous-triggers] | ||
| workflow_run: | ||
| workflows: [update and build] | ||
| types: [completed] |
There was a problem hiding this comment.
Does this include failures, lint-epub will need gating for that as otherwise it'll scream when it tries to download the artefact.
By splitting workflows we get a better, gradual feedback and state of things expression.
Building without strict mode, we can add back strict mode as a separate workflow (or as part of linting?) in the future.
Unable to test workflow run trigger before the PR is merged into main.
To do:
-Wflag); corresponding job called withmake dist-pdfdoesn't fail: https://github.com/m-aciek/python-docs-offline/actions/runs/27127952047/job/80061499030