Skip to content

GH-95736: fix IsolatedAsyncioTestCase to set event loop before calling setup functions #95898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 6 commits into from
Aug 16, 2022
+20 −0
Merged

GH-95736: fix IsolatedAsyncioTestCase to set event loop before calling setup functions #95898

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f96d467
fix IsolatedAsyncioTestCase to set event loop
kumaraditya303 Aug 11, 2022
02f369b
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 11, 2022
bec4f9e
Merge branch 'main' of https://github.com/python/cpython into fix-uni…
kumaraditya303 Aug 15, 2022
bf77bb6
add comment & simplify
kumaraditya303 Aug 15, 2022
06cdeea
simplify
kumaraditya303 Aug 16, 2022
3324354
code review
kumaraditya303 Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
code review
  • Loading branch information
@kumaraditya303
kumaraditya303 authored Aug 16, 2022
commit 33243540d5839e48d45525551dbc9d620ae1ddd3
2 changes: 1 addition & 1 deletion Lib/test/test_unittest/test_async_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ def test_setup_get_event_loop(self):

class TestCase1(unittest.IsolatedAsyncioTestCase):
def setUp(self):
self.loop = asyncio.get_event_loop_policy().get_event_loop()
asyncio.get_event_loop_policy().get_event_loop()

async def test_demo1(self):
pass
Expand Down
4 changes: 3 additions & 1 deletion Lib/unittest/async_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ def _setupAsyncioRunner(self):
assert self._asyncioRunner is None, 'asyncio runner is already initialized'
runner = asyncio.Runner(debug=True)
self._asyncioRunner = runner
# Force loop to be initialized
# Force loop to be initialized and set as the current loop
# so that setUp functions can use get_event_loop() and get the
# correct loop instance.
runner.get_loop()
Comment thread
kumaraditya303 marked this conversation as resolved.

def _tearDownAsyncioRunner(self):
Expand Down