Skip to content

GH-95736: fix IsolatedAsyncioTestCase to set event loop before calling setup functions #95898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 6 commits into from
Aug 16, 2022
Merged

GH-95736: fix IsolatedAsyncioTestCase to set event loop before calling setup functions #95898

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f96d467
fix IsolatedAsyncioTestCase to set event loop
kumaraditya303 Aug 11, 2022
02f369b
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 11, 2022
bec4f9e
Merge branch 'main' of https://github.com/python/cpython into fix-uni…
kumaraditya303 Aug 15, 2022
bf77bb6
add comment & simplify
kumaraditya303 Aug 15, 2022
06cdeea
simplify
kumaraditya303 Aug 16, 2022
3324354
code review
kumaraditya303 Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify
  • Loading branch information
@kumaraditya303
kumaraditya303 authored Aug 16, 2022
commit 06cdeea7c0c2f874f1a7a47cda70ed51ce7de1b3
21 changes: 6 additions & 15 deletions Lib/test/test_unittest/test_async_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,28 +436,19 @@ async def cleanup(self, fut):

def test_setup_get_event_loop(self):
# See https://github.com/python/cpython/issues/95736
events = []
# Make sure the default event loop is not used
asyncio.set_event_loop(None)

class TestCase1(unittest.IsolatedAsyncioTestCase):
def setUp(self):
self.loop = asyncio.get_event_loop_policy().get_event_loop()
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated

async def test_demo1(self):
events.append('called demo1')


class TestCase2(unittest.IsolatedAsyncioTestCase):
def setUp(self):
self.loop = asyncio.get_event_loop_policy().get_event_loop()

async def test_demo2(self):
events.append('called demo2')
pass

test = TestCase1('test_demo1')
test.debug()
self.assertEqual(events, ['called demo1'])
test = TestCase2('test_demo2')
test.debug()
self.assertEqual(events, ['called demo1', 'called demo2'])
result = test.run()
self.assertTrue(result.wasSuccessful())

if __name__ == "__main__":
unittest.main()