Skip to content

bpo-27777 Fix for several reported cgi.py issues#7804

Closed
eykamp wants to merge 2 commits into
python:mainfrom
eykamp:issue-27777
Closed

bpo-27777 Fix for several reported cgi.py issues#7804
eykamp wants to merge 2 commits into
python:mainfrom
eykamp:issue-27777

Conversation

@eykamp
Copy link
Copy Markdown

@eykamp eykamp commented Jun 19, 2018 •
edited
Loading

This is primarily a repackaging of the fixes proposed by Bert JW Regeer.

https://bugs.python.org/issue27777

@eykamp eykamp changed the title bpo-277777 Fix for several reported cgi.py issues bpo-27777 Fix for several reported cgi.py issues Jun 19, 2018
@ned-deily
Copy link
Copy Markdown
Member

ned-deily commented Jun 22, 2018

@eykamp Looks like the change causes another test case to fail. See the Travis or VSTS CI details:

======================================================================
2018-06-19T19:19:06.7474160Z ERROR: test_parse_multipart_invalid_encoding (test.test_cgi.CgiTests)
2018-06-19T19:19:06.7490910Z ----------------------------------------------------------------------
2018-06-19T19:19:06.7507040Z Traceback (most recent call last):
2018-06-19T19:19:06.7522140Z   File "/Users/vsts/agent/2.134.2/work/1/s/Lib/test/test_cgi.py", line 146, in test_parse_multipart_invalid_encoding
2018-06-19T19:19:06.7537280Z     self.assertEqual(result, expected)
2018-06-19T19:19:06.7552850Z   File "/Users/vsts/agent/2.134.2/work/1/s/Lib/unittest/case.py", line 839, in assertEqual
2018-06-19T19:19:06.7567860Z     assertion_func(first, second, msg=msg)
2018-06-19T19:19:06.7582800Z   File "/Users/vsts/agent/2.134.2/work/1/s/Lib/unittest/case.py", line 1132, in assertDictEqual
2018-06-19T19:19:06.7597610Z     if d1 != d2:
2018-06-19T19:19:06.7612250Z BytesWarning: Comparison between bytes and string

@PierreQuentel
Copy link
Copy Markdown
Contributor

PierreQuentel commented Nov 29, 2018

I have submitted another PR, #10771, to solve the issue.

@MoodyMudit
Copy link
Copy Markdown

MoodyMudit commented May 16, 2019

Hi, This change seems to fix the bug. When is this change going to be merged and sent out?

@rr rr mannequin mentioned this pull request Apr 11, 2022
Closed
@AlexWaygood
Copy link
Copy Markdown
Member

AlexWaygood commented Apr 11, 2022 •
edited
Loading

@eykamp, thanks for the PR. Unfortunately, the cgi module is now deprecated following the acceptance of PEP 594, so bugfixes and improvements for this module will no longer be accepted. I am therefore closing this PR.

I hope that this does not dissuade you from contributing to CPython in the future 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eykamp @ned-deily @PierreQuentel @MoodyMudit @AlexWaygood @the-knights-who-say-ni @bedevere-bot