bpo-27777 : cgi.FieldStorage can't parse simple body with Con…#10771
Closed
PierreQuentel wants to merge 2 commits into
Closed
bpo-27777 : cgi.FieldStorage can't parse simple body with Con…#10771PierreQuentel wants to merge 2 commits into
PierreQuentel wants to merge 2 commits into
Conversation
…tent-Length and no Content-Disposition.
ar45
reviewed
Feb 5, 2019
|
|
||
| def read_single(self): | ||
| """Internal: read an atomic part.""" | ||
| self.read_lines() |
There was a problem hiding this comment.
I just tested this patch locally. Seems like with some clients, the webserver will not get a EOF if the client sent content-length header. So the this will result in an indefinite block on fp.readline(). We should honor the content-length, and not try to read more than that in any case.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tent-Length and no Content-Disposition.
https://bugs.python.org/issue27777