Skip to content

bpo-26680: Incorporate is_integer in all built-in and standard library numeric types #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 10 commits into from
Oct 1, 2020
Merged

bpo-26680: Incorporate is_integer in all built-in and standard library numeric types #6121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d80b017
bpo-26680: Adds support for int.is_integer() for compatibility with f…
rob-smallshire Mar 13, 2018
b46a9dc
bpo-26680: Adds a test to ensure that False.is_integer() and True.is_…
rob-smallshire Mar 13, 2018
3b1677f
bpo-26680: Adds Real.is_integer() with a trivial implementation using…
rob-smallshire Mar 13, 2018
f78bf5c
bpo-26680: Adds Rational.is_integer which returns True if the denomin…
rob-smallshire Mar 13, 2018
6a905a8
bpo-26680: Adds Integral.is_integer which always returns True.
rob-smallshire Mar 13, 2018
cc07ee5
bpo-26680: Adds tests for Fraction.is_integer called as an instance m…
rob-smallshire Mar 13, 2018
3ae9866
bpo-26680: Updates documentation for Real.is_integer and built-ins in…
rob-smallshire Mar 14, 2018
54ca820
bpo-26680: Adds Decimal.is_integer to the Python and C implementations.
rob-smallshire Mar 14, 2018
a9e364d
bpo-26680: Updates the ACKS file.
rob-smallshire Mar 15, 2018
11db7f8
bpo-26680: NEWS entries for int, the numeric ABCs and Decimal.
rob-smallshire Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-26680: Adds support for int.is_integer() for compatibility with f… 
…loat.is_integer().

The int.is_integer() method always returns True.
  • Loading branch information
@rob-smallshire
rob-smallshire committed Sep 18, 2020
commit d80b01737c4691b3d42f49b3852913c21d1c1e8f
4 changes: 4 additions & 0 deletions Lib/test/test_long.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,6 +1381,10 @@ class myint(int):
self.assertEqual(type(numerator), int)
self.assertEqual(type(denominator), int)

def test_int_always_is_integer(self):
# Issue #26680: Incorporating number.is_integer into int
self.assertTrue(all(x.is_integer() for x in (-1, 0, 1, 42)))


if __name__ == "__main__":
unittest.main()
20 changes: 19 additions & 1 deletion Objects/clinic/longobject.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5233,6 +5233,19 @@ int___round___impl(PyObject *self, PyObject *o_ndigits)
return result;
}

/*[clinic input]
int.is_integer

Returns True for all integers.
[clinic start generated code]*/

static PyObject *
Copy link
Copy Markdown
Member

@mdickinson mdickinson May 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we convert this to Argument Clinic? It seems somewhat trivial, but one advantage is having the docstring close to the definition. Another is having docstring consistency between int.is_integer and float.is_integer.

Copy link
Copy Markdown
Contributor Author

@rob-smallshire rob-smallshire Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

int_is_integer_impl(PyObject *self)
/*[clinic end generated code: output=90f8e794ce5430ef input=903121d57b734c35]*/
{
Py_RETURN_TRUE;
}

/*[clinic input]
int.__sizeof__ -> Py_ssize_t

Expand Down Expand Up @@ -5547,6 +5560,7 @@ static PyMethodDef long_methods[] = {
{"__ceil__", long_long_meth, METH_NOARGS,
"Ceiling of an Integral returns itself."},
INT___ROUND___METHODDEF
INT_IS_INTEGER_METHODDEF
INT___GETNEWARGS___METHODDEF
INT___FORMAT___METHODDEF
INT___SIZEOF___METHODDEF
Expand Down