Skip to content

bpo-26680: Incorporate is_integer in all built-in and standard library numeric types #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 10 commits into from
Oct 1, 2020
Merged

bpo-26680: Incorporate is_integer in all built-in and standard library numeric types #6121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d80b017
bpo-26680: Adds support for int.is_integer() for compatibility with f…
rob-smallshire Mar 13, 2018
b46a9dc
bpo-26680: Adds a test to ensure that False.is_integer() and True.is_…
rob-smallshire Mar 13, 2018
3b1677f
bpo-26680: Adds Real.is_integer() with a trivial implementation using…
rob-smallshire Mar 13, 2018
f78bf5c
bpo-26680: Adds Rational.is_integer which returns True if the denomin…
rob-smallshire Mar 13, 2018
6a905a8
bpo-26680: Adds Integral.is_integer which always returns True.
rob-smallshire Mar 13, 2018
cc07ee5
bpo-26680: Adds tests for Fraction.is_integer called as an instance m…
rob-smallshire Mar 13, 2018
3ae9866
bpo-26680: Updates documentation for Real.is_integer and built-ins in…
rob-smallshire Mar 14, 2018
54ca820
bpo-26680: Adds Decimal.is_integer to the Python and C implementations.
rob-smallshire Mar 14, 2018
a9e364d
bpo-26680: Updates the ACKS file.
rob-smallshire Mar 15, 2018
11db7f8
bpo-26680: NEWS entries for int, the numeric ABCs and Decimal.
rob-smallshire Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-26680: Adds Integral.is_integer which always returns True.
  • Loading branch information
@rob-smallshire
rob-smallshire committed Sep 18, 2020
commit 6a905a8f95c2d52a10bfaebea0687c1514836375
4 changes: 4 additions & 0 deletions Lib/numbers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,4 +401,8 @@ def denominator(self):
"""Integers have a denominator of 1."""
return 1

def is_integer(self):
"""Return True; all Integrals represent an integral value."""
return True

Integral.register(int)
6 changes: 6 additions & 0 deletions Lib/test/test_numeric_tower.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,12 @@ def test_rational_is_integer(self):
self.assertFalse(Rational.is_integer(F(1, 3)))
self.assertFalse(Rational.is_integer(F(2, 3)))

def test_integral_is_integer(self):
self.assertTrue(Integral.is_integer(-1))
self.assertTrue(Integral.is_integer(0))
self.assertTrue(Integral.is_integer(1))
self.assertTrue(Integral.is_integer(1729))


if __name__ == '__main__':
unittest.main()