Skip to content

gh-75710: IDLE: Add tests to some editor.py functions #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csabella wants to merge 15 commits into
base: main
Choose a base branch
from
+417 −6
Open

gh-75710: IDLE: Add tests to some editor.py functions #3669

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c21d679
IDLE: Add docstrings and tests for editor.py
csabella Sep 17, 2017
d047c39
Add blurb
csabella Sep 20, 2017
435ea82
Merge branch 'master' into binding_tests
terryjreedy Sep 21, 2020
ac8dae4
Synchronize tkinter import in test_editor
terryjreedy Sep 21, 2020
eb25140
Update test_editor.py
terryjreedy Sep 21, 2020
8dfbd49
Remove test of removed _filename_to_unicode method.
terryjreedy Sep 21, 2020
0308f80
Remove unneeded extra underscore.
terryjreedy Sep 21, 2020
c32379b
Make test pass; delete redundant asserts.
terryjreedy Sep 21, 2020
ba274a4
Docstring and comment and a couple code revisions.
terryjreedy Sep 21, 2020
b5d80cb
Merge branch 'master' into binding_tests
terryjreedy Jan 25, 2021
3fbf6da
Merge remote-tracking branch 'upstream/master' into pr_3669
terryjreedy Feb 20, 2021
0aea634
Merge remote-tracking branch 'upstream/main' into pr_3669
terryjreedy May 13, 2023
cf8044e
whitespace
terryjreedy May 13, 2023
fba2ef2
Merge branch 'main' into binding_tests
terryjreedy May 13, 2023
47ebc2d
Merge branch 'main' into binding_tests
terryjreedy May 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make test pass; delete redundant asserts.
  • Loading branch information
@terryjreedy
terryjreedy committed Sep 21, 2020
commit c32379be1f998e608162a176171989e4f5081c5c
24 changes: 9 additions & 15 deletions Lib/idlelib/idle_test/test_editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ def test_fill_menus(self):
def test_reset_help_menu_entries(self, mock_extrahelp):
w = self.mock_editwin
mock_extrahelp.return_value = [('Python', 'https://python.org', '1')]
mock_callback = w._EditorWindow__extra_help_callback
mock_callback = w._extra_help_callback

# Create help menu.
help = w.menudict['help'] = tk.Menu(w.menubar, name='help', tearoff=False)
Expand Down Expand Up @@ -435,24 +435,18 @@ def test__extra_help_callback_not_windows(self, mock_openfile):

@mock.patch.object(editor.os, 'startfile')
@unittest.skipIf(not sys.platform.startswith('win'), 'this is test for windows system')
def test__extra_help_callback_windows(self, mock_openfile):
def test_extra_help_callback_windows(self, mock_start):
# os.startfile doesn't exist on other platforms.
w = self.mock_editwin
ehc = partial(w._EditorWindow__extra_help_callback, w)

w.showerror = mock.Mock()
def ehc(source):
return Editor._extra_help_callback(w, source)
ehc('http://python.org')
mock_openfile.called_with('http://python.org')
ehc('www.python.org')
mock_openfile.called_with('www.python.org')
# Filename that opens successfully.
mock_openfile.return_value = True
ehc('/foo/bar/baz/')
mock_openfile.called_with('\\foo\\bar\\baz')
mock_start.called_with('http://python.org')
# Filename that doesn't open.
mock_openfile.return_value = False
with self.assertRaises(OSError):
ehc('/foo/bar/baz/')
self.assertEqual(w.showerror.title, 'Document Start Failure')
mock_start.side_effect = OSError('boom')
ehc('/foo/bar/baz/')()
self.assertTrue(w.showerror.callargs.kwargs)


class BindingsTest(unittest.TestCase):
Expand Down