Skip to content

gh-75710: IDLE: Add tests to some editor.py functions #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csabella wants to merge 15 commits into
base: main
Choose a base branch
from
Open

gh-75710: IDLE: Add tests to some editor.py functions #3669

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c21d679
IDLE: Add docstrings and tests for editor.py
csabella Sep 17, 2017
d047c39
Add blurb
csabella Sep 20, 2017
435ea82
Merge branch 'master' into binding_tests
terryjreedy Sep 21, 2020
ac8dae4
Synchronize tkinter import in test_editor
terryjreedy Sep 21, 2020
eb25140
Update test_editor.py
terryjreedy Sep 21, 2020
8dfbd49
Remove test of removed _filename_to_unicode method.
terryjreedy Sep 21, 2020
0308f80
Remove unneeded extra underscore.
terryjreedy Sep 21, 2020
c32379b
Make test pass; delete redundant asserts.
terryjreedy Sep 21, 2020
ba274a4
Docstring and comment and a couple code revisions.
terryjreedy Sep 21, 2020
b5d80cb
Merge branch 'master' into binding_tests
terryjreedy Jan 25, 2021
3fbf6da
Merge remote-tracking branch 'upstream/master' into pr_3669
terryjreedy Feb 20, 2021
0aea634
Merge remote-tracking branch 'upstream/main' into pr_3669
terryjreedy May 13, 2023
cf8044e
whitespace
terryjreedy May 13, 2023
fba2ef2
Merge branch 'main' into binding_tests
terryjreedy May 13, 2023
47ebc2d
Merge branch 'main' into binding_tests
terryjreedy May 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneeded extra underscore.
  • Loading branch information
@terryjreedy
terryjreedy committed Sep 21, 2020
commit 0308f80548ee65676ebff5a8a50f0df89dc8fe52
5 changes: 2 additions & 3 deletions Lib/idlelib/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,6 @@ def set_line_and_column(self, event=None):
("help", "_Help"),
]


def createmenubar(self):
"""Populate the menu bar widget for the editor window.

Expand Down Expand Up @@ -944,12 +943,12 @@ def reset_help_menu_entries(self):
if help_list:
helpmenu.add_separator()
for entry in help_list:
cmd = self.__extra_help_callback(entry[1])
cmd = self._extra_help_callback(entry[1])
helpmenu.add_command(label=entry[0], command=cmd)
# And update the menu dictionary.
self.menudict['help'] = helpmenu

def __extra_help_callback(self, helpfile):
def _extra_help_callback(self, helpfile):
"""Create a callback with the helpfile value frozen at definition time.

Args:
Copy link
Copy Markdown
Contributor

@taleinat taleinat Aug 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style of describing args in doc-strings is non-standard. I think it would be shorter and simpler to just remove the "Args:" heading, and change the "Returns:" section into a single line of text.

Likewise for other methods.

Copy link
Copy Markdown
Member

@terryjreedy terryjreedy Sep 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Cheryl did this PR after we refactored configdialog. For that, we had some exceptionally wordy docstrings to keep things clear. This docstring should start with 'Return...'

Expand Down