Skip to content

bpo-46528: Simplify the VM's stack manipulations #30902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 10 commits into from
Jan 26, 2022
Merged

bpo-46528: Simplify the VM's stack manipulations #30902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb5ec74
Replace ROT*/DUP* with SWAP/COPY
brandtbucher Jan 25, 2022
415c9b2
Catch up with main
brandtbucher Jan 25, 2022
96f0ce5
Implement a "swaptimizer"
brandtbucher Jan 25, 2022
1ab5f21
Simplify things further
brandtbucher Jan 26, 2022
d85d65b
blurb add
brandtbucher Jan 26, 2022
1f67c08
Fix typo
brandtbucher Jan 26, 2022
c4ef99f
Clean up wording
brandtbucher Jan 26, 2022
6274309
Remove VLA usage
brandtbucher Jan 26, 2022
aa51caa
Apply feedback from code review
brandtbucher Jan 26, 2022
1537cda
Naming is hard
brandtbucher Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
blurb add
  • Loading branch information
@brandtbucher
brandtbucher committed Jan 26, 2022
commit d85d65bff6b7526290602f892149a3f3923c252b
5 changes: 3 additions & 2 deletions Doc/whatsnew/3.11.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,9 @@ CPython bytecode changes
indicate failure with :const:`None` (where a tuple of extracted values would
otherwise be).

* Added :opcode:`COPY`, which pushes the *i*-th item to the top of the stack.
The item is not removed from its original location.
* Replace several stack manipulation instructions (``DUP_TOP``, ``DUP_TOP_TWO``,
``ROT_TWO``, ``ROT_THREE``, ``ROT_FOUR``, and ``ROT_N``) with new
:opcode:`COPY` and new :opcode:`SWAP` instructions.

* Add :opcode:`POP_JUMP_IF_NOT_NONE` and :opcode:`POP_JUMP_IF_NONE` opcodes to
speed up conditional jumps.
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-01-25-17-40-07.bpo-46528.2Qmni9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Replace several stack manipulation instructions (``DUP_TOP``,
``DUP_TOP_TWO``, ``ROT_TWO``, ``ROT_THREE``, ``ROT_FOUR``, and ``ROT_N``)
with the existing :opcode:`COPY` and new :opcode:`SWAP` instructions.