Skip to content

bpo-46528: Simplify the VM's stack manipulations #30902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 10 commits into from
Jan 26, 2022
Merged

bpo-46528: Simplify the VM's stack manipulations #30902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb5ec74
Replace ROT*/DUP* with SWAP/COPY
brandtbucher Jan 25, 2022
415c9b2
Catch up with main
brandtbucher Jan 25, 2022
96f0ce5
Implement a "swaptimizer"
brandtbucher Jan 25, 2022
1ab5f21
Simplify things further
brandtbucher Jan 26, 2022
d85d65b
blurb add
brandtbucher Jan 26, 2022
1f67c08
Fix typo
brandtbucher Jan 26, 2022
c4ef99f
Clean up wording
brandtbucher Jan 26, 2022
6274309
Remove VLA usage
brandtbucher Jan 26, 2022
aa51caa
Apply feedback from code review
brandtbucher Jan 26, 2022
1537cda
Naming is hard
brandtbucher Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Catch up with main
  • Loading branch information
@brandtbucher
brandtbucher committed Jan 25, 2022
commit 415c9b2321994707a0b836a309b6b6d263321959
2 changes: 1 addition & 1 deletion Include/opcode.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,8 @@ def _write_atomic(path, data, mode=0o666):
# Python 3.11a4 3473 (Add POP_JUMP_IF_NOT_NONE/POP_JUMP_IF_NONE opcodes)
# Python 3.11a4 3474 (Add RESUME opcode)
# Python 3.11a5 3475 (Add RETURN_GENERATOR opcode)
# Python 3.11a5 3476 (Replace DUP_TOP/DUP_TOP_TWO with COPY and
# Python 3.11a5 3476 (Add ASYNC_GEN_WRAP opcode)
# Python 3.11a5 3477 (Replace DUP_TOP/DUP_TOP_TWO with COPY and
# ROT_TWO/ROT_THREE/ROT_FOUR/ROT_N with SWAP)

# Python 3.12 will start with magic number 3500
Expand All @@ -396,7 +397,7 @@ def _write_atomic(path, data, mode=0o666):
# Whenever MAGIC_NUMBER is changed, the ranges in the magic_values array
# in PC/launcher.c must also be updated.

MAGIC_NUMBER = (3476).to_bytes(2, 'little') + b'\r\n'
MAGIC_NUMBER = (3477).to_bytes(2, 'little') + b'\r\n'
_RAW_MAGIC_NUMBER = int.from_bytes(MAGIC_NUMBER, 'little') # For import.c

_PYCACHE = '__pycache__'
Expand Down
6 changes: 3 additions & 3 deletions Python/opcode_targets.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

You are viewing a condensed version of this merge commit. You can view the full changes here.