Skip to content

bpo-45400: Fix test_name_error_suggestions_do_not_trigger_for_too_many_locals on a1 releases #28784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hroncok wants to merge 1 commit into from
Closed

bpo-45400: Fix test_name_error_suggestions_do_not_trigger_for_too_many_locals on a1 releases #28784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Lib/test/test_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1840,7 +1840,13 @@ def f():
with support.captured_stderr() as err:
sys.__excepthook__(*sys.exc_info())

self.assertNotIn("a1", err.getvalue())
traceback = err.getvalue()

# remvoe the source path from the traceback, it could contain "a1" in it
# https://bugs.python.org/issue45400
traceback = traceback.replace(__file__, os.path.basename(__file__))

self.assertNotIn("a1", traceback)

def test_name_error_with_custom_exceptions(self):
def f():
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Tests/2021-10-07-13-17-42.bpo-45400.oHgprZ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
The ``test_name_error_suggestions_do_not_trigger_for_too_many_locals`` will
no longer fail when run from a directory that contains ``a1`` in the path,
which is likely to happen when building from unpacked sources of a first
alpha release.