bpo-45400: Fix test_name_error_suggestions_do_not_trigger_for_too_many_locals on a1 releases#28784
Closed
hroncok wants to merge 1 commit into
Closed
bpo-45400: Fix test_name_error_suggestions_do_not_trigger_for_too_many_locals on a1 releases#28784hroncok wants to merge 1 commit into
hroncok wants to merge 1 commit into
Conversation
…y_locals on a1 releases When test_name_error_suggestions_do_not_trigger_for_too_many_locals run from a directory that contained "a1" somewhere in the path, which was likely to happen when building from unpacked sources of a first alpha release, it failed, as it asserts the string "a1" is nowhere in the traceback. Now, we replace the full path in the traceback with basename to prevent this.
Contributor
Author
|
never mind, #28783 is probably a better fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When test_name_error_suggestions_do_not_trigger_for_too_many_locals
run from a directory that contained "a1" somewhere in the path,
which was likely to happen when building from unpacked sources of a first
alpha release, it failed, as it asserts the string "a1" is nowhere in the traceback.
Now, we replace the full path in the traceback with basename to prevent this.
https://bugs.python.org/issue45400