Skip to content

gh-56708: support custom len function in textwrap.wrap #28136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xi wants to merge 12 commits into
base: main
Choose a base branch
from
Open

gh-56708: support custom len function in textwrap.wrap #28136

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
df3f367
bpo-12499: textwrap.wrap: add control for fonts with different charac…
xi Sep 3, 2021
97a2ec8
react to feedback
xi Sep 3, 2021
db82b6c
typo
xi Sep 3, 2021
f457e20
fix missing len occurences
xi Sep 3, 2021
e164780
add more tests
xi Sep 4, 2021
09ce4ce
fix idle test
xi Sep 5, 2021
bf8dad5
optimize text_len function
xi Sep 5, 2021
68e8098
fixup
xi Oct 13, 2021
e5d6d88
_find_width_index and _handle_long_word change
tiptenbrink Nov 9, 2021
7b32d0b
Apply changes, ensure min 1 char on line
tiptenbrink Nov 10, 2021
b811049
Merge pull request #2 from tiptenbrink/textwrap-len
xi Nov 11, 2021
95fcafd
Merge branch 'main' into textwrap-len
serhiy-storchaka Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo
  • Loading branch information
@xi
xi committed Sep 3, 2021
commit db82b6cdc04e3ed7f4628b6840742060d7c933c4
2 changes: 1 addition & 1 deletion Lib/test/test_textwrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ def text_len(text):

text = "123 🔧"
expected = ["123", "🔧"]
self.check_wrap(text, 6, expected, text_len=text_len)
self.check_wrap(text, 5, expected, text_len=text_len)
Copy link
Copy Markdown
Member

@merwok merwok Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that more tests are needed; text_len is used at multiple places in the code.

Copy link
Copy Markdown
Member

@merwok merwok Sep 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests! Could some of them use different texts?

Copy link
Copy Markdown
Author

@xi xi Sep 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to avoid adding example for languages that I do not speak myself (e.g. Chinese). Are there ways to reach out to the wider community to provide meaningful examples?



if __name__ == '__main__':
Expand Down