Skip to content

gh-56708: support custom len function in textwrap.wrap #28136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xi wants to merge 12 commits into
base: main
Choose a base branch
from
Open

gh-56708: support custom len function in textwrap.wrap #28136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
df3f367
bpo-12499: textwrap.wrap: add control for fonts with different charac…
xi Sep 3, 2021
97a2ec8
react to feedback
xi Sep 3, 2021
db82b6c
typo
xi Sep 3, 2021
f457e20
fix missing len occurences
xi Sep 3, 2021
e164780
add more tests
xi Sep 4, 2021
09ce4ce
fix idle test
xi Sep 5, 2021
bf8dad5
optimize text_len function
xi Sep 5, 2021
68e8098
fixup
xi Oct 13, 2021
e5d6d88
_find_width_index and _handle_long_word change
tiptenbrink Nov 9, 2021
7b32d0b
Apply changes, ensure min 1 char on line
tiptenbrink Nov 10, 2021
b811049
Merge pull request #2 from tiptenbrink/textwrap-len
xi Nov 11, 2021
95fcafd
Merge branch 'main' into textwrap-len
serhiy-storchaka Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
react to feedback
  • Loading branch information
@xi
xi committed Sep 3, 2021
commit 97a2ec81f13e87ca5a9f89488bf633c3dfa86f91
2 changes: 2 additions & 0 deletions Doc/library/textwrap.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,8 @@ hyphenated words; only then will long words be broken if necessary, unless
(default: ``len``) Used to determine the length of a string. You can
provide a custom function, e.g. to account for wide characters.
Comment thread
merwok marked this conversation as resolved.

.. versionadded:: 3.11


.. index:: single: ...; placeholder

Expand Down
11 changes: 4 additions & 7 deletions Lib/test/test_textwrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,22 +1078,19 @@ def test_first_word_too_long_but_placeholder_fits(self):


class WideCharacterTestCase(BaseTestCase):
def setUp(self):
def test_wide_character(self):
def text_len(text):
n = 0
for c in text:
if unicodedata.east_asian_width(c) in ['F', 'W']:
if unicodedata.east_asian_width(c) in {'F', 'W'}:
n += 2
else:
n += 1
return n

self.wrapper = TextWrapper(width=5, text_len=text_len)

def test_wide_character(self):
text = "123 🔧"
result = self.wrapper.wrap(text, **kwargs)
self.check(result, ["123", "🔧"])
expected = ["123", "🔧"]
self.check_wrap(text, 6, expected, text_len=text_len)


if __name__ == '__main__':
Expand Down
4 changes: 2 additions & 2 deletions Lib/textwrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ def _wrap_chunks(self, chunks):
indent = self.subsequent_indent
else:
indent = self.initial_indent
if self.text_len(indent) +
self.text_len(self.placeholder.lstrip()) > self.width:
if (self.text_len(indent) +
self.text_len(self.placeholder.lstrip()) > self.width):
raise ValueError("placeholder too large for max width")

# Arrange in reverse order so items can be efficiently popped
Expand Down