Skip to content

bpo-30274: Rename 'name' to 'fullname' argument to ExtensionFileLoader. #26195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zkneupper wants to merge 3 commits into from
Closed

bpo-30274: Rename 'name' to 'fullname' argument to ExtensionFileLoader. #26195

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bbdf39
Update __init__ signature for ExtensionFileLoader
May 17, 2021
312f356
Handle name kwarg
May 17, 2021
e641d1e
Removing name kwarg because it leads to errors
May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,8 +1162,8 @@ class ExtensionFileLoader(FileLoader, _LoaderBasics):

"""

def __init__(self, name, path):
self.name = name
def __init__(self, fullname, path):
Copy link
Copy Markdown
Contributor

@DimitrisJim DimitrisJim May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to make name deprecated first and then switch to only allowing fullname.

self.name = fullname
self.path = path

def __eq__(self, other):
Expand Down