bpo-30274: Rename 'name' to 'fullname' argument to ExtensionFileLoader.#26195
Closed
zkneupper wants to merge 3 commits into
Closed
bpo-30274: Rename 'name' to 'fullname' argument to ExtensionFileLoader.#26195zkneupper wants to merge 3 commits into
zkneupper wants to merge 3 commits into
Conversation
DimitrisJim
reviewed
May 31, 2021
|
|
||
| def __init__(self, name, path): | ||
| self.name = name | ||
| def __init__(self, fullname, path): |
Contributor
There was a problem hiding this comment.
The idea is to make name deprecated first and then switch to only allowing fullname.
Contributor
|
If you'd like to pick this up, I'd suggest you work on sayanchowdhury's PR and take care of the conflicts. That PR has already been reviewed and has been (basically) accepted, the issues brought up only need to be resolved. |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-30274: Rename
nametofullnameargument to ExtensionFileLoader.This PR replaces the positional argument
namefor the ExtensionFileLoader class with the positional argumentfullname.Old:
__init__(self, name, path):New:
__init__(self, fullname, path):nameis not added as a kwarg, unlike in #1735In PR #1735:
fullnamearg andnamekwarg (andpatharg) were passed.patharg andnamekwarg were passed,pathwould be the first positional argument, acting asfullname, and this would raise an errorbpo: https://bugs.python.org/issue30274
https://bugs.python.org/issue30274