Skip to content

bpo-44136: remove pathlib._Flavour #26141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barneygale wants to merge 14 commits into from
Closed

bpo-44136: remove pathlib._Flavour #26141

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3655d5e
Remove `flavour.is_reserved()`
barneygale May 14, 2021
0faa6d0
Remove `flavour.make_uri()`
barneygale May 14, 2021
3094398
Remove `flavour.join()`, `flavour.sep` and `flavour.altsep`
barneygale May 14, 2021
00f6126
Remove `flavour.join_parsed_parts()`
barneygale May 14, 2021
6ea7eae
Remove `flavour.parse_parts()`, `flavour.splitroot()` and `flavour.pa…
barneygale May 15, 2021
66f5453
Remove `flavour.compile_pattern()`
barneygale May 15, 2021
3d27707
Remove `flavour.is_supported`
barneygale May 15, 2021
b4beecc
Remove `flavour.has_drv`.
barneygale May 15, 2021
3cf15c6
Remove `flavour.casefold()` and `flavour.casefold_parts()`
barneygale May 15, 2021
0897d9d
Remove `_Flavour`, `_WindowsFlavour` and `_PosixFlavour`
barneygale May 15, 2021
4e918e4
Simplify Path construction.
barneygale May 15, 2021
f0beb66
Move Windows constants to module scope.
barneygale May 15, 2021
22942e4
Remove `Path._supported`
barneygale May 15, 2021
6f9fd60
Move `PurePosixPath._splitroot()`, `is_absolute()` and `is_reserved()…
barneygale May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove flavour.has_drv.
  • Loading branch information
@barneygale
barneygale committed May 15, 2021
commit b4beecc71e1bb5c117e51e6022982b6c1bac56d8
14 changes: 7 additions & 7 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ class _WindowsFlavour(_Flavour):
# Reference for Windows paths can be found at
# http://msdn.microsoft.com/en-us/library/aa365247%28v=vs.85%29.aspx

has_drv = True

def casefold(self, s):
return s.lower()

Expand All @@ -65,8 +63,6 @@ def casefold_parts(self, parts):


class _PosixFlavour(_Flavour):
has_drv = False

def casefold(self, s):
return s

Expand Down Expand Up @@ -737,9 +733,7 @@ def parents(self):
def is_absolute(self):
"""True if the path is absolute (has both a root and, if applicable,
a drive)."""
if not self._root:
return False
return not self._flavour.has_drv or bool(self._drv)
raise NotImplementedError

def is_reserved(self):
"""Return True if the path contains one of the special names reserved
Expand Down Expand Up @@ -805,6 +799,9 @@ def _splitroot(cls, part):
else:
return '', '', part

def is_absolute(self):
return bool(self._root)

def is_reserved(self):
return False

Expand Down Expand Up @@ -894,6 +891,9 @@ def _split_extended_path(cls, s, ext_prefix=_ext_namespace_prefix):
s = '\\' + s[3:]
return prefix, s

def is_absolute(self):
return bool(self._root) and bool(self._drv)

def is_reserved(self):
# NOTE: the rules for reserved names seem somewhat complicated
# (e.g. r"..\NUL" is reserved but not r"foo\NUL").
Expand Down