Skip to content

bpo-44136: remove pathlib._Flavour #26141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barneygale wants to merge 14 commits into from
Closed

bpo-44136: remove pathlib._Flavour #26141

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3655d5e
Remove `flavour.is_reserved()`
barneygale May 14, 2021
0faa6d0
Remove `flavour.make_uri()`
barneygale May 14, 2021
3094398
Remove `flavour.join()`, `flavour.sep` and `flavour.altsep`
barneygale May 14, 2021
00f6126
Remove `flavour.join_parsed_parts()`
barneygale May 14, 2021
6ea7eae
Remove `flavour.parse_parts()`, `flavour.splitroot()` and `flavour.pa…
barneygale May 15, 2021
66f5453
Remove `flavour.compile_pattern()`
barneygale May 15, 2021
3d27707
Remove `flavour.is_supported`
barneygale May 15, 2021
b4beecc
Remove `flavour.has_drv`.
barneygale May 15, 2021
3cf15c6
Remove `flavour.casefold()` and `flavour.casefold_parts()`
barneygale May 15, 2021
0897d9d
Remove `_Flavour`, `_WindowsFlavour` and `_PosixFlavour`
barneygale May 15, 2021
4e918e4
Simplify Path construction.
barneygale May 15, 2021
f0beb66
Move Windows constants to module scope.
barneygale May 15, 2021
22942e4
Remove `Path._supported`
barneygale May 15, 2021
6f9fd60
Move `PurePosixPath._splitroot()`, `is_absolute()` and `is_reserved()…
barneygale May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove Path._supported
  • Loading branch information
@barneygale
barneygale committed May 15, 2021
commit 22942e40a22c399658e5925b0211c942107833c0
5 changes: 2 additions & 3 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,6 @@ class PurePosixPath(PurePath):
However, you can also instantiate it directly on any system.
"""
_pathmod = posixpath
_supported = (os.name != 'nt')
_case_insensitive = False
__slots__ = ()

Expand Down Expand Up @@ -813,7 +812,6 @@ class PureWindowsPath(PurePath):
# Reference for Windows paths can be found at
# http://msdn.microsoft.com/en-us/library/aa365247%28v=vs.85%29.aspx
_pathmod = ntpath
_supported = (os.name == 'nt')
_case_insensitive = True
__slots__ = ()

Expand Down Expand Up @@ -922,7 +920,8 @@ class Path(PurePath):
def __new__(cls, *args, **kwargs):
if cls is Path:
cls = WindowsPath if os.name == 'nt' else PosixPath
elif not cls._supported:
elif (issubclass(cls, PosixPath) and os.name == 'nt') or \
(issubclass(cls, WindowsPath) and os.name != 'nt'):
raise NotImplementedError("cannot instantiate %r on your system"
% (cls.__name__,))
return cls._from_parts(args)
Expand Down