Skip to content

bpo-43917: Fix descriptor documentation example error#25541

Closed
yahor-harunovich wants to merge 1 commit into
python:masterfrom
yahor-harunovich:fix-issue-43917
Closed

bpo-43917: Fix descriptor documentation example error#25541
yahor-harunovich wants to merge 1 commit into
python:masterfrom
yahor-harunovich:fix-issue-43917

Conversation

@yahor-harunovich
Copy link
Copy Markdown

@yahor-harunovich yahor-harunovich commented Apr 22, 2021

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Titanolodon

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@rhettinger
Copy link
Copy Markdown
Contributor

Fixed in: #25544

Differences:

  • To match C, added type
  • Added tests
  • Added OP to Misc/ACKS
  • Credited the OP in the check-in message

@rhettinger rhettinger closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants