Skip to content

bpo-43917: Fix descriptor documentation example error #25541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yahor-harunovich wants to merge 1 commit into from
Closed

bpo-43917: Fix descriptor documentation example error #25541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Doc/howto/descriptor.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1329,7 +1329,7 @@ Using the non-data descriptor protocol, a pure Python version of
def __get__(self, obj, cls=None):
if cls is None:
cls = type(obj)
if hasattr(obj, '__get__'):
if hasattr(self.f, '__get__'):
return self.f.__get__(cls)
return MethodType(self.f, cls)

Expand All @@ -1353,7 +1353,7 @@ Using the non-data descriptor protocol, a pure Python version of
>>> t.cm(11, 22)
(<class 'T'>, 11, 22)

The code path for ``hasattr(obj, '__get__')`` was added in Python 3.9 and
The code path for ``hasattr(self.f, '__get__')`` was added in Python 3.9 and
makes it possible for :func:`classmethod` to support chained decorators.
For example, a classmethod and property could be chained together:

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Documentation/2021-04-22-23-18-26.bpo-bpo-43917.d-1T5G.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed example python implementation of classmethod in the documentation of descriptor.