Skip to content

bpo-43318: Fix a bug where pdb does not always echo cleared breakpoints. #24646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 11 commits into from
Jun 11, 2021
Merged

bpo-43318: Fix a bug where pdb does not always echo cleared breakpoints. #24646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
16c9a22
bpo-43318: pdb can't output the prompt message when successfully clea…
Feb 25, 2021
aef3abd
add unit test for bpo-43318
Feb 26, 2021
387e322
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 25, 2021
693be3f
fix unit test issue
Apr 22, 2021
49ef2ff
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 22, 2021
fcbeacc
Update Lib/test/test_pdb.py
hjzin Jun 11, 2021
593666a
Update Misc/NEWS.d/next/Library/2021-02-25-08-32-06.bpo-43318.bZJw6V.rst
hjzin Jun 11, 2021
a8e639f
remove redundant rst file
Jun 11, 2021
064d426
Fix whitespace
iritkatriel Jun 11, 2021
0577eae
Add blank line at end of new test function
iritkatriel Jun 11, 2021
df58705
remove extra spaces
iritkatriel Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ def do_clear(self, arg):
except ValueError:
err = "Invalid line number (%s)" % arg
else:
bplist = self.get_breaks(filename, lineno)
bplist = self.get_breaks(filename, lineno)[:]
err = self.clear_break(filename, lineno)
if err:
self.error(err)
Expand Down
29 changes: 29 additions & 0 deletions Lib/test/test_pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,6 +1322,35 @@ def test_pdb_issue_20766():
pdb 2: <built-in function default_int_handler>
"""

def test_pdb_issue_43318():
"""echo breakpoints cleared with filename:lineno

>>> def test_function():
... import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace()
... print(1)
... print(2)
... print(3)
... print(4)
>>> reset_Breakpoint()
>>> with PdbTestInput([ # doctest: +NORMALIZE_WHITESPACE
... 'break 3',
... 'clear <doctest test.test_pdb.test_pdb_issue_43318[0]>:3',
... 'continue'
... ]):
... test_function()
> <doctest test.test_pdb.test_pdb_issue_43318[0]>(3)test_function()
-> print(1)
(Pdb) break 3
Breakpoint 1 at <doctest test.test_pdb.test_pdb_issue_43318[0]>:3
(Pdb) clear <doctest test.test_pdb.test_pdb_issue_43318[0]>:3
Deleted breakpoint 1 at <doctest test.test_pdb.test_pdb_issue_43318[0]>:3
(Pdb) continue
1
2
3
4
"""
Comment thread
iritkatriel marked this conversation as resolved.


class PdbTestCase(unittest.TestCase):
def tearDown(self):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2021-02-25-08-32-06.bpo-43318.bZJw6V.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug where :mod:`pdb` does not always echo cleared breakpoints.