Skip to content

bpo-43318: Fix a bug where pdb does not always echo cleared breakpoints.#24646

Merged
iritkatriel merged 11 commits into
python:mainfrom
hjzin:pdb_fix
Jun 11, 2021
Merged

bpo-43318: Fix a bug where pdb does not always echo cleared breakpoints.#24646
iritkatriel merged 11 commits into
python:mainfrom
hjzin:pdb_fix

Conversation

@hjzin

@hjzin hjzin commented Feb 25, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue43318

In Pdb, when successfully clear breakpoints, the Pdb should output a message:"Deleted XXX", but when breakpoints are cleared by filename:lineno, the message can't be output.

I think it's related to the following code.

pdb.py:

def do_clear(self, arg):
    ...
  
    if ':' in arg:
        # Make sure it works for "clear C:\foo\bar.py:12"
        i = arg.rfind(':')
        filename = arg[:i]
        arg = arg[i+1:]
        try:
            lineno = int(arg)
        except ValueError:
            err = "Invalid line number (%s)" % arg
        else:
            bplist = self.get_breaks(filename, lineno)
            err = self.clear_break(filename, lineno)
        if err:
            self.error(err)
        else:
            for bp in bplist:
                self.message('Deleted %s' % bp)
        return

self.get_breaks is called to get the breakpoints to be deleted, the result is in bplist. self.clear_break is called to delete the breakpoints in bplist. Each element in bplist is a reference to a Breakpoint object, so when all Breakpoint objects are removed, the bplist will become an empty list when self.clear_break is called, so pdb can't output the prompt message.

It can be simply fixed by following code:

    bplist = self.get_breaks(filename, lineno)[:]

https://bugs.python.org/issue43318

@the-knights-who-say-ni

the-knights-who-say-ni commented Feb 25, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@hjzin

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions

github-actions Bot commented Mar 30, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Mar 30, 2021
iritkatriel
iritkatriel reviewed Jun 10, 2021
View reviewed changes
Comment thread Lib/test/test_pdb.py Outdated
Comment thread Misc/NEWS.d/next/Library/2021-04-22-08-34-46.bpo-43318.Rztyvu.rst Outdated

@iritkatriel iritkatriel Jun 10, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two news files - this one can be deleted.

Comment thread Misc/NEWS.d/next/Library/2021-02-25-08-32-06.bpo-43318.bZJw6V.rst Outdated
@iritkatriel

iritkatriel commented Jun 10, 2021

Copy link
Copy Markdown
Member

Please also resolve the merge conflict on test_pdb.py (rebase your branch).

@hjzin

hjzin commented Jun 11, 2021

Copy link
Copy Markdown
Contributor Author

Please also resolve the merge conflict on test_pdb.py (rebase your branch).

I have rebased my branch, please review again.

iritkatriel
iritkatriel reviewed Jun 11, 2021
View reviewed changes
Comment thread Lib/test/test_pdb.py Outdated
iritkatriel
iritkatriel reviewed Jun 11, 2021
View reviewed changes
Comment thread Lib/test/test_pdb.py
@iritkatriel iritkatriel added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section needs backport to 3.9 needs backport to 3.10 only security fixes labels Jun 11, 2021
@iritkatriel iritkatriel added the type-bug An unexpected behavior, bug, or error label Jun 11, 2021
@bedevere-bot

bedevere-bot commented Jun 11, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 0577eae 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 11, 2021
@iritkatriel

iritkatriel commented Jun 11, 2021

Copy link
Copy Markdown
Member

Thank you @hjzin . This looks good now. I will merge once the tests have run.

@iritkatriel iritkatriel changed the title bpo-43318: pdb can't output the prompt message when successfully clear breakpoints by "filename:lineno" bpo-43318: Fix a bug where pdb does not always echo cleared breakpoints. Jun 11, 2021
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 11, 2021
@bedevere-bot

bedevere-bot commented Jun 11, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit df58705 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 11, 2021
@iritkatriel iritkatriel merged commit 4cb6ba1 into python:main Jun 11, 2021
@miss-islington

miss-islington commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

Thanks @hjzin for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2021
@hjzin @miss-islington
bpo-43318: Fix a bug where pdb does not always echo cleared breakpoin…
777c2c4 
…ts (pythonGH-24646)

(cherry picked from commit 4cb6ba1)

Co-authored-by: huzhaojie <hu.zj@foxmail.com>
@bedevere-bot

bedevere-bot commented Jun 11, 2021

Copy link
Copy Markdown

GH-26674 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 11, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2021
@hjzin @miss-islington
bpo-43318: Fix a bug where pdb does not always echo cleared breakpoin…
419bf6b 
…ts (pythonGH-24646)

(cherry picked from commit 4cb6ba1)

Co-authored-by: huzhaojie <hu.zj@foxmail.com>
@bedevere-bot

bedevere-bot commented Jun 11, 2021

Copy link
Copy Markdown

GH-26675 is a backport of this pull request to the 3.9 branch.

iritkatriel pushed a commit that referenced this pull request Jun 11, 2021
@miss-islington @hjzin
bpo-43318: Fix a bug where pdb does not always echo cleared breakpoin…
9c0180a 
…ts (GH-24646) (GH-26674)

(cherry picked from commit 4cb6ba1)

Co-authored-by: huzhaojie <hu.zj@foxmail.com>
iritkatriel pushed a commit that referenced this pull request Jun 11, 2021
@miss-islington @hjzin
bpo-43318: Fix a bug where pdb does not always echo cleared breakpoin…
6df926f 
…ts (GH-24646) (GH-26675)

(cherry picked from commit 4cb6ba1)

Co-authored-by: huzhaojie <hu.zj@foxmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time. type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hjzin @the-knights-who-say-ni @iritkatriel @bedevere-bot @miss-islington