Skip to content

[3.14] gh-155974: Add a test for the window attributes after a failed write - #156565

Merged
serhiy-storchaka merged 1 commit into
python:3.14from
serhiy-storchaka:guard-155974-3.14
Aug 29, 2026
Merged

[3.14] gh-155974: Add a test for the window attributes after a failed write#156565
serhiy-storchaka merged 1 commit into
python:3.14from
serhiy-storchaka:guard-155974-3.14

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 29, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

A write with an attr restores the window rendition afterwards, whether it succeeded or failed. This branch does the right thing already -- the regression fixed by #155975 was introduced in 3.15 by 30dde1e, which is not here -- so this only adds the test as a guard.

The test reads the rendition by writing a cell with it and reading that cell back with inch(), since window.getattrs() is 3.16 only.

@serhiy-storchaka
pythongh-155974: Add a test for the window attributes after a failed …
e8d871d 
…write

The bug was introduced and fixed in 3.15, but the behaviour is worth
guarding here too.
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Aug 29, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 29, 2026
Closed
@serhiy-storchaka
serhiy-storchaka merged commit 563449b into python:3.14 Aug 29, 2026
55 checks passed
@serhiy-storchaka
serhiy-storchaka deleted the guard-155974-3.14 branch August 29, 2026 15:34
@bedevere-bot

bedevere-bot commented Aug 29, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO + PGO 3.14 (tier-3) has failed when building commit 563449b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1699/builds/1318) and take a look at the build logs.
  4. Check if the failure is related to this commit (563449b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1699/builds/1318

Summary of the results of the build (if available):

Click to see traceback logs 
Note: switching to '563449b182ee9b2a4b7704985c5f2c50675cd3ab'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 563449b182ee [3.14] gh-155974: Add a test for the window attributes after a failed write (GH-156565)
Switched to and reset branch '3.14'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:3398: clean-retain-profile] Error 1 (ignored)
./Modules/socketmodule.c: In function ‘getsockaddrarg’:
./Modules/socketmodule.c:2646:9: warning: ‘strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
 2646 |         strncpy((char *)sa->salg_name, name, sizeof(sa->salg_name));
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ar: libpython3.14.a: error reading Modules/_io/textio.o: No space left on device
make[2]: *** [Makefile:1180: libpython3.14.a] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1012: profile-gen-stamp] Error 2
make: *** [Makefile:1024: profile-run-stamp] Error 2

@bedevere-bot

bedevere-bot commented Aug 29, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO 3.14 (tier-3) has failed when building commit 563449b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1731/builds/1305) and take a look at the build logs.
  4. Check if the failure is related to this commit (563449b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1731/builds/1305

Summary of the results of the build (if available):

Click to see traceback logs 
Note: switching to '563449b182ee9b2a4b7704985c5f2c50675cd3ab'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 563449b182ee [3.14] gh-155974: Add a test for the window attributes after a failed write (GH-156565)
Switched to and reset branch '3.14'

ar: libpython3.14.a: error reading Python/Python-ast.o: No space left on device
make: *** [Makefile:1180: libpython3.14.a] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-curses

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @bedevere-bot