[3.14] gh-155974: Add a test for the window attributes after a failed write - #156565
Open
serhiy-storchaka wants to merge 1 commit into
Open
[3.14] gh-155974: Add a test for the window attributes after a failed write#156565serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…write The bug was introduced and fixed in 3.15, but the behaviour is worth guarding here too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A write with an attr restores the window rendition afterwards, whether it succeeded or failed. This branch does the right thing already -- the regression fixed by #155975 was introduced in 3.15 by 30dde1e, which is not here -- so this only adds the test as a guard.
The test reads the rendition by writing a cell with it and reading that cell back with
inch(), sincewindow.getattrs()is 3.16 only.addstrno longer restores the window attributes when the write fails #155974