gh-155912: Handle PermissionError from os.sysconf under sandbox - #155955
Closed
imabd645 wants to merge 4 commits into
Closed
gh-155912: Handle PermissionError from os.sysconf under sandbox#155955imabd645 wants to merge 4 commits into
imabd645 wants to merge 4 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
The issue's OP suggested to open a PR themselves, please ask them first if they want to still do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where
concurrent.futures.ProcessPoolExecutorfails to construct on macOS (and other environments) when run under a strict sandbox profile that deniessysctlreads.When the sandbox denies access,
os.sysconf("SC_SEM_NSEMS_MAX")raises aPermissionError(a subclass ofOSError). Previously,_check_system_limits()only caughtAttributeErrorandValueError, meaning thePermissionErrorpropagated up and fatally broke the executor initialization, even though the underlying semaphore primitives were fully functional.Changes:
OSErrorto the caught exceptions in_check_system_limits()inLib/concurrent/futures/process.py, allowing the executor to gracefully fall back to assuming an undetermined limit when read access is denied.Lib/test/test_concurrent_futures/test_process_pool.pythat mocksos.sysconfto simulate a strict sandbox and asserts that theProcessPoolExecutorinitializes successfully.