bpo-32554: Deprecate hashing arbitrary types in random.seed()#15382
Merged
Conversation
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I am just interesting, why implement a warning in random.Random.seed() instead of _random.Random.seed()?
|
|
||
| .. deprecated:: 3.9 | ||
| In the future, the *seed* must be one of the following types: | ||
| :class:`NoneType`, :class:`int`, :class:`float`, :class:`str`, |
Member
There was a problem hiding this comment.
There is no an entry for NoneType, so the link will not work.
Member
There was a problem hiding this comment.
Is float because of seed(time.time())?
| elif not isinstance(a, (type(None), int, float, str, bytes, bytearray)): | ||
| _warn('Seeding based on hashing is deprecated\n' | ||
| 'since Python 3.9 and will be removed in a subsequent ' | ||
| 'version. The only \nsupported seed types are: None, ' |
Member
There was a problem hiding this comment.
I would break a string literal and a line after \n for readability
| possible seed value. Unfortunately, some of those types are not | ||
| guaranteed to have a deterministic hash value. After Python 3.9, | ||
| the module will restrict its seeds to *None*, :class:`int`, | ||
| :class:`float`, :class:`str`, :class:`bytes`, and :class:`bytearray'. |
Member
There was a problem hiding this comment.
Suggested change
| :class:`float`, :class:`str`, :class:`bytes`, and :class:`bytearray'. | |
| :class:`float`, :class:`str`, :class:`bytes`, and :class:`bytearray`. |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
2 tasks
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Contributor
|
Excuse my density and lateness, but why was this feature deprecated and removed instead of being fixed? Couldn't you use a non-random hash? The Python standard library already provides a wide variety of hashes in |
Member
|
It is unrelated. |
ngnpope
added a commit
to ngnpope/mimesis
that referenced
this pull request
Nov 26, 2021
Makes the following changes: - Added `float` to the `Union` for `Seed`. - Added `None` to the `Union` for `Seed`. - Replaced `Optional[Seed]` with `Seed` everywhere. See the following links for details: - https://bugs.python.org/issue32554 - python/cpython#15382 - https://docs.python.org/3.9/library/random.html#random.seed Currently `typeshed` is still using `Any`.
ngnpope
added a commit
to ngnpope/mimesis
that referenced
this pull request
Nov 26, 2021
Makes the following changes: - Added `float` to the `Union` for `Seed`. - Added `None` to the `Union` for `Seed`. - Replaced `Optional[Seed]` with `Seed` everywhere. See the following links for details: - https://bugs.python.org/issue32554 - python/cpython#15382 - https://docs.python.org/3.9/library/random.html#random.seed Currently `typeshed` is still using `Any`.
2 tasks
ngnpope
added a commit
to ngnpope/mimesis
that referenced
this pull request
Nov 27, 2021
Makes the following changes: - Added `float` to the `Union` for `Seed`. - Added `None` to the `Union` for `Seed`. - Replaced `Optional[Seed]` with `Seed` everywhere. See the following links for details: - https://bugs.python.org/issue32554 - python/cpython#15382 - https://docs.python.org/3.9/library/random.html#random.seed Currently `typeshed` is still using `Any`.
ngnpope
added a commit
to ngnpope/mimesis
that referenced
this pull request
Nov 30, 2021
Makes the following changes: - Added `float` to the `Union` for `Seed`. - Added `None` to the `Union` for `Seed`. - Replaced `Optional[Seed]` with `Seed` everywhere. See the following links for details: - https://bugs.python.org/issue32554 - python/cpython#15382 - https://docs.python.org/3.9/library/random.html#random.seed Currently `typeshed` is still using `Any`.
lk-geimfari
pushed a commit
to lk-geimfari/mimesis
that referenced
this pull request
Nov 30, 2021
Makes the following changes: - Added `float` to the `Union` for `Seed`. - Added `None` to the `Union` for `Seed`. - Replaced `Optional[Seed]` with `Seed` everywhere. See the following links for details: - https://bugs.python.org/issue32554 - python/cpython#15382 - https://docs.python.org/3.9/library/random.html#random.seed Currently `typeshed` is still using `Any`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32554