Skip to content

Commit 70ded86

Browse files
ngnpopengnpope
committed
Fix types for Seed.
Makes the following changes: - Added `float` to the `Union` for `Seed`. - Added `None` to the `Union` for `Seed`. - Replaced `Optional[Seed]` with `Seed` everywhere. See the following links for details: - https://bugs.python.org/issue32554 - python/cpython#15382 - https://docs.python.org/3.9/library/random.html#random.seed Currently `typeshed` is still using `Any`.
1 parent 2e1c880 commit 70ded86

12 files changed

Lines changed: 21 additions & 21 deletions

File tree

‎mimesis/builtins/da.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
"""Specific data provider for Denmark (da)."""
44
import operator
5-
from typing import Final, Optional, Tuple
5+
from typing import Final, Tuple
66

77
from mimesis import Datetime
88
from mimesis.builtins.base import BaseSpecProvider
@@ -15,7 +15,7 @@
1515
class DenmarkSpecProvider(BaseSpecProvider):
1616
"""Class that provides special data for Denmark (da)."""
1717

18-
def __init__(self, seed: Optional[Seed] = None) -> None:
18+
def __init__(self, seed: Seed = None) -> None:
1919
"""Initialize attributes."""
2020
super().__init__(locale=Locale.DA, seed=seed)
2121
self._datetime = Datetime(locale=Locale.DA, seed=seed)

‎mimesis/builtins/en.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
"""Specific data provider for USA (en)."""
44

5-
from typing import Final, Optional
5+
from typing import Final
66

77
from mimesis.builtins.base import BaseSpecProvider
88
from mimesis.locales import Locale
@@ -14,7 +14,7 @@
1414
class USASpecProvider(BaseSpecProvider):
1515
"""Class that provides special data for USA (en)."""
1616

17-
def __init__(self, seed: Optional[Seed] = None) -> None:
17+
def __init__(self, seed: Seed = None) -> None:
1818
"""Initialize attributes."""
1919
super().__init__(locale=Locale.EN, seed=seed)
2020

‎mimesis/builtins/it.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
class ItalySpecProvider(BaseSpecProvider):
1717
"""Specific-provider of misc data for Italy."""
1818

19-
def __init__(self, seed: Optional[Seed] = None) -> None:
19+
def __init__(self, seed: Seed = None) -> None:
2020
"""Initialize attributes."""
2121
super().__init__(locale=Locale.IT, seed=seed)
2222
self._load_datafile(self._datafile)

‎mimesis/builtins/nl.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
"""Specific data provider for Netherlands (nl)."""
44

5-
from typing import Final, Optional
5+
from typing import Final
66

77
from mimesis.builtins.base import BaseSpecProvider
88
from mimesis.locales import Locale
@@ -14,7 +14,7 @@
1414
class NetherlandsSpecProvider(BaseSpecProvider):
1515
"""Class that provides special data for Netherlands (nl)."""
1616

17-
def __init__(self, seed: Optional[Seed] = None) -> None:
17+
def __init__(self, seed: Seed = None) -> None:
1818
"""Initialize attributes."""
1919
super().__init__(locale=Locale.NL, seed=seed)
2020

‎mimesis/builtins/pl.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
class PolandSpecProvider(BaseSpecProvider):
1717
"""Class that provides special data for Poland (pl)."""
1818

19-
def __init__(self, seed: Optional[Seed] = None) -> None:
19+
def __init__(self, seed: Seed = None) -> None:
2020
"""Initialize attributes."""
2121
super().__init__(locale=Locale.PL, seed=seed)
2222

‎mimesis/builtins/pt_br.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# -*- coding: utf-8 -*-
22

33
"""Specific data provider for Brazil (pt-br)."""
4-
from typing import Final, List, Optional
4+
from typing import Final, List
55

66
from mimesis.builtins.base import BaseSpecProvider
77
from mimesis.locales import Locale
@@ -14,7 +14,7 @@
1414
class BrazilSpecProvider(BaseSpecProvider):
1515
"""Class that provides special data for Brazil (pt-br)."""
1616

17-
def __init__(self, seed: Optional[Seed] = None) -> None:
17+
def __init__(self, seed: Seed = None) -> None:
1818
"""Initialize attributes."""
1919
super().__init__(locale=Locale.PT_BR, seed=seed)
2020

‎mimesis/builtins/ru.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
class RussiaSpecProvider(BaseSpecProvider):
1717
"""Class that provides special data for Russia (ru)."""
1818

19-
def __init__(self, seed: Optional[Seed] = None) -> None:
19+
def __init__(self, seed: Seed = None) -> None:
2020
"""Initialize attributes."""
2121
super().__init__(locale=Locale.RU, seed=seed)
2222
self._load_datafile(self._datafile)

‎mimesis/builtins/uk.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# -*- coding: utf-8 -*-
22

33
"""Specific data provider for Ukraine (uk)."""
4-
from typing import Final, List, Optional
4+
from typing import Final, List
55

66
from mimesis.builtins.base import BaseSpecProvider
77
from mimesis.enums import Gender
@@ -14,7 +14,7 @@
1414
class UkraineSpecProvider(BaseSpecProvider):
1515
"""Class that provides special data for Ukraine (uk)."""
1616

17-
def __init__(self, seed: Optional[Seed] = None) -> None:
17+
def __init__(self, seed: Seed = None) -> None:
1818
"""Initialize attributes."""
1919
super().__init__(locale=Locale.UK, seed=seed)
2020
self._load_datafile(self._datafile)

‎mimesis/providers/base.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
class BaseProvider:
2222
"""This is a base class for all providers."""
2323

24-
def __init__(self, *, seed: Optional[Seed] = None, **kwargs: Any) -> None:
24+
def __init__(self, *, seed: Seed = None, **kwargs: Any) -> None:
2525
"""Initialize attributes.
2626
2727
Keep in mind, that locale-independent data providers will work
@@ -36,7 +36,7 @@ def __init__(self, *, seed: Optional[Seed] = None, **kwargs: Any) -> None:
3636
if seed is not None:
3737
self.reseed(seed)
3838

39-
def reseed(self, seed: Optional[Seed] = None) -> None:
39+
def reseed(self, seed: Seed = None) -> None:
4040
"""Reseed the internal random generator.
4141
4242
In case we use the default seed, we need to create a per instance
@@ -80,7 +80,7 @@ class BaseDataProvider(BaseProvider):
8080
_LOCALE_SEPARATOR = "-"
8181

8282
def __init__(
83-
self, locale: Locale = Locale.DEFAULT, seed: Optional[Seed] = None
83+
self, locale: Locale = Locale.DEFAULT, seed: Seed = None
8484
) -> None:
8585
"""Initialize attributes for data providers.
8686

‎mimesis/providers/generic.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"""Provides all at one."""
44

55
import inspect
6-
from typing import Any, Final, List, Optional, Type
6+
from typing import Any, Final, List, Type
77

88
from mimesis.locales import Locale
99
from mimesis.providers.address import Address
@@ -58,7 +58,7 @@ class Generic(BaseProvider):
5858
)
5959

6060
def __init__(
61-
self, locale: Locale = Locale.DEFAULT, seed: Optional[Seed] = None
61+
self, locale: Locale = Locale.DEFAULT, seed: Seed = None
6262
) -> None:
6363
"""Initialize attributes lazily."""
6464
super().__init__(seed=seed)
@@ -112,7 +112,7 @@ def __dir__(self) -> List[str]:
112112
attributes.append(a)
113113
return attributes
114114

115-
def reseed(self, seed: Optional[Seed] = None) -> None:
115+
def reseed(self, seed: Seed = None) -> None:
116116
"""Reseed the internal random generator.
117117
118118
Overrides method `BaseProvider.reseed()`.

0 commit comments

Comments
 (0)