Skip to content

Re-raise unexpected exceptions instead of swallowing them in tests #152019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aisk wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

Re-raise unexpected exceptions instead of swallowing them in tests #152019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae1639e
Re-raise unexpected exceptions instead of swallowing them in tests
aisk Jun 23, 2026
2c2f096
Re-raise unexpected exceptions in test_launcher's test_search_major_2
aisk Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/test/test_fcntl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ def test_fcntl_64_bit(self):
except OSError as exc:
if exc.errno == errno.EINVAL:
self.skipTest("F_NOTIFY not available by this environment")
raise
fcntl.fcntl(fd, cmd, flags)
finally:
os.close(fd)
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,7 @@ def test_search_major_2(self):
except subprocess.CalledProcessError:
if not is_installed("2.7"):
raise unittest.SkipTest("requires at least one Python 2.x install")
raise
self.assertEqual("PythonCore", data["env.company"])
self.assertStartsWith(data["env.tag"], "2.")

Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_pathlib/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2870,6 +2870,7 @@ def test_is_socket_true(self):
if (isinstance(e, PermissionError) or
"AF_UNIX path too long" in str(e)):
self.skipTest("cannot bind Unix socket: " + str(e))
raise
self.assertTrue(P.is_socket())
self.assertFalse(P.is_fifo())
self.assertFalse(P.is_file())
Expand Down
2 changes: 2 additions & 0 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1427,6 +1427,7 @@ def testIPv6toString(self):
except OSError as e:
if e.winerror == 10022:
self.skipTest('IPv6 might not be supported')
raise

f = lambda a: inet_pton(AF_INET6, a)
assertInvalid = lambda a: self.assertRaises(
Expand Down Expand Up @@ -1517,6 +1518,7 @@ def testStringToIPv6(self):
except OSError as e:
if e.winerror == 10022:
self.skipTest('IPv6 might not be supported')
raise

f = lambda a: inet_ntop(AF_INET6, a)
assertInvalid = lambda a: self.assertRaises(
Expand Down
Loading