Re-raise unexpected exceptions instead of swallowing them in tests#152019
Open
aisk wants to merge 2 commits into
Open
Re-raise unexpected exceptions instead of swallowing them in tests#152019aisk wants to merge 2 commits into
aisk wants to merge 2 commits into
Conversation
Member
|
Nice catch! I asked Claude to search for more of these, and it came back with one more:
From a glance, it seems correct (although we're unlikely to hit it on most systems), but I think we can include it here. |
Co-authored-by: Stan Ulbrych <stan@python.org>
Member
Author
|
@StanFromIreland Thank you for the review, updated! |
|
🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit 2c2f096 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F152019%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Member
|
Looks good, but let's run the Buildbots, just to be safe, since these are all quite platform specific cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fixing #137420, I found that some existing test code swallows exceptions it doesn't care about.
I think these are simple, test only fixes, so the issue and the news entry aren't required.