gh-148467: Move BufferedIOBase close to concrete implementations#150838
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-148467: Move BufferedIOBase close to concrete implementations#150838serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
This reverts commit b6c7beb.
Member
Author
|
@birkenfeld, @benjaminp, please take a look. |
Documentation build overview
|
StanFromIreland
approved these changes
Jul 5, 2026
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
LGTM. You have to fix the conflicts, however.
cmaloney
approved these changes
Jul 5, 2026
cmaloney
reviewed
Jul 5, 2026
| implies writing, so this mode behaves in a similar way to ``'w'``. Add a | ||
| ``'+'`` to the mode to allow simultaneous reading and writing. | ||
|
|
||
| The :meth:`~RawIOBase.read` (when called with a positive argument), |
Contributor
Contributor
There was a problem hiding this comment.
(They retry for EINTR, they don't retry for partial read or write)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b6c7beb.