Skip to content

gh-150232: Change Thread group parameter doc from 'should be' to 'must be' #150243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
My-ABC wants to merge 3 commits into from
+1 −1
Closed

gh-150232: Change Thread group parameter doc from 'should be' to 'must be' #150243

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e7cf3a
gh-150232: Change Thread group parameter doc from 'should be' to 'mus…
My-ABC May 22, 2026
3e11308
Merge branch 'main' into fix-threading-group-doc
My-ABC May 22, 2026
49aa8c4
Merge branch 'main' into fix-threading-group-doc
My-ABC May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Doc/library/threading.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ since it is impossible to detect the termination of alien threads.
This constructor should always be called with keyword arguments. Arguments
are:

*group* should be ``None``; reserved for future extension when a
*group* **must** be ``None``; reserved for future extension when a
Copy link
Copy Markdown
Member

@picnixz picnixz May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*group* **must** be ``None``; reserved for future extension when a
*group* must be ``None`` as it is reserved for future extension when a

Copy link
Copy Markdown
Contributor Author

@My-ABC My-ABC May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I've applied the suggestion.

:class:`!ThreadGroup` class is implemented.

*target* is the callable object to be invoked by the :meth:`run` method.
Expand Down
Loading