gh-150232: Change Thread group parameter doc from 'should be' to 'must be'#150243
Closed
My-ABC wants to merge 3 commits into
Closed
gh-150232: Change Thread group parameter doc from 'should be' to 'must be'#150243My-ABC wants to merge 3 commits into
My-ABC wants to merge 3 commits into
Conversation
Documentation build overview
|
|
All commit authors signed the Contributor License Agreement. |
picnixz
reviewed
May 22, 2026
| are: | ||
|
|
||
| *group* should be ``None``; reserved for future extension when a | ||
| *group* **must** be ``None``; reserved for future extension when a |
Member
There was a problem hiding this comment.
Suggested change
| *group* **must** be ``None``; reserved for future extension when a | |
| *group* must be ``None`` as it is reserved for future extension when a |
Author
There was a problem hiding this comment.
Thanks for the review! I've applied the suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation for threading.Thread to accurately reflect the implementation.
The implementation uses assert group is None, which makes the parameter mandatory. The documentation is updated from "should be None" to "must be None".
Fixes #150232