gh-146581: Update docs for dangerous filenames in ZIP files#149994
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-146581: Update docs for dangerous filenames in ZIP files#149994serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Documentation build overview
|
| @@ -750,7 +750,7 @@ provided. They rely on the :mod:`zipfile` and :mod:`tarfile` modules. | |||
| Never extract archives from untrusted sources without prior inspection. | |||
| It is possible that files are created outside of the path specified in | |||
| the *extract_dir* argument, e.g. members that have absolute filenames | |||
Member
There was a problem hiding this comment.
Suggested change
| the *extract_dir* argument, e.g. members that have absolute filenames | |
| the *extract_dir* argument, for example, members that have absolute filenames |
Can we fix this while we're here please. We should not have latin abbreviations.
| the :meth:`ZipFile.extract` and :meth:`ZipFile.extractall` methods, it is the | ||
| caller's responsibility to validate or sanitize filenames to prevent path traversal | ||
| vulnerabilities (e.g., filenames containing ".." or absolute paths). When handling | ||
| vulnerabilities (e.g., absolute paths or paths with ".." cmponents). When handling |
Member
There was a problem hiding this comment.
Suggested change
| vulnerabilities (e.g., absolute paths or paths with ".." cmponents). When handling | |
| vulnerabilities (for example, absolute paths or paths with ".." components). When handling |
Latin abbreviation here too, and a typo.
| @@ -412,8 +412,8 @@ ZipFile objects | |||
|
|
|||
| Never extract archives from untrusted sources without prior inspection. | |||
| It is possible that files are created outside of *path*, e.g. members | |||
Member
There was a problem hiding this comment.
Suggested change
| It is possible that files are created outside of *path*, e.g. members | |
| It is possible that files are created outside of *path*, for example, members |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.