Skip to content

gh-148651: Fix Py_DECREF(value) leak in _zstd decompressor options #148657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmatyping merged 1 commit into from
Apr 17, 2026
+3 −0
Merged

gh-148651: Fix Py_DECREF(value) leak in _zstd decompressor options #148657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-148651: Fix Py_DECREF(value) leak in _zstd decompressor options
  • Loading branch information
@mjbommar
mjbommar committed Apr 16, 2026
commit e45b490becfed8f1ad7cccf6b237b1e10c53fdad
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-04-16-13-30-00.gh-issue-148651.ZsTdLk.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix reference leak in :class:`compression.zstd.ZstdDecompressor` when an
invalid option key is passed.
1 change: 1 addition & 0 deletions Modules/_zstd/decompressor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ _zstd_set_d_parameters(ZstdDecompressor *self, PyObject *options)
int key_v = PyLong_AsInt(key);
Py_DECREF(key);
if (key_v == -1 && PyErr_Occurred()) {
Py_DECREF(value);
return -1;
}

Expand Down
Loading